Most of those 10 squashed commits likely had commit comments like: "Cleanup base... | Hacker News

Hacker Newsnew | past | comments | ask | show | jobs | submit

		Yeroc 26 days ago \| parent \| context \| favorite \| on: Git Rebase for the Terrified Most of those 10 squashed commits likely had commit comments like: "Cleanup based on PR feedback." etc.

drysine 26 days ago [–]

That's what --amend and --fixup are for.

cmrdporcupine 26 days ago | [–]

Which wreaks havoc with githubs shitty code review tool.

Which is an argument against GitHub, not clean commit history

cluckindan 26 days ago | | [–]

Yep. Rebase rewrites history and all the PR review comments vanish.

drysine 24 days ago | | [–]

Gitlab seems fine with it

Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact