Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

> I know a lot of people want to maintain the history of each PR, but you won't need it in your VCS.

Having worked on a maintenance team for years, this is just wrong. You don't know what someone will or won't need in the future. Those individual commits have had extra context that have been a massive help for me all sorts of times.

I'm fine with manually squashing individual "fix typo"-style commits, but just squashing the entire branch removes too much.



Disagree!

If those commits were ready for production, they would have been merged. ;)

Don't put a commit on main unless I can roll back to it.


When your PR build takes more than an hour you'll think twice before creating multiple PRs for multiple related commits (e.g. refactoring+feature) when working on a single issue.


That's fine and fair, but you'd better squash them then :)




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: